[Merged by Bors] - Useful changes with relicensing benefits #2497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obsoletes bevyengine#1111
This makes more sense when we are talking about the wgpu project as a whole Obsoletes bevyengine#2445
github-actions
bot
added
S-Needs-Triage
DJMcNab
removed
the
S-Pre-Relicense
Member
|
I think you mentioned the wrong person. |
Member
Author
|
Indeed, you're the second person to point that out. I've already edited it. |
alice-i-cecile
approved these changes
Jul 17, 2021
Member
|
Cool cool. I think we should delete cases like this from the list instead of checking them off (to avoid thinking they agreed to the relicense). |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 17, 2021
This obsoletes #1111 and #2445, since @ColonisationCaptain and @temhotaokeaha haven't replied to #2373. I believe that both of those PRs would be fine to keep, but they're even more fine to keep now :)
Member
|
Eh we should add a "changes obsoleted" category and move them there. |
Contributor
bors
bot
changed the title
Member
|
Updated #2373 |
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
This obsoletes bevyengine#1111 and bevyengine#2445, since @ColonisationCaptain and @temhotaokeaha haven't replied to bevyengine#2373. I believe that both of those PRs would be fine to keep, but they're even more fine to keep now :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This obsoletes #1111 and #2445, since @ColonisationCaptain and @temhotaokeaha haven't replied to #2373.
I believe that both of those PRs would be fine to keep, but they're even more fine to keep now :)