[Merged by Bors] - Make Remove Command's fields public #2449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An oversight on bevyengine#2034
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Jul 11, 2021
Member
|
could you comment on #2373 if you're OK with the license change? |
Member
|
bors try |
mockersf
approved these changes
Jul 11, 2021
mockersf
added
the
S-Ready-For-Final-Review
Contributor
tryBuild failed: |
Author
|
Build failed due to a network error. |
Member
|
bors try |
Contributor
tryBuild failed: |
Author
|
Build failed again due to a network issue, although this time with a different crate, but in the same stage. |
Contributor
|
bors try |
Contributor
tryBuild succeeded: |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 12, 2021
In #2034, the `Remove` Command did not get the same treatment as the rest of the commands. There's no discussion saying it shouldn't have public fields, so I am assuming it was an oversight. This fixes that oversight.
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
In bevyengine#2034, the `Remove` Command did not get the same treatment as the rest of the commands. There's no discussion saying it shouldn't have public fields, so I am assuming it was an oversight. This fixes that oversight.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2034, the
RemoveCommand did not get the same treatment as the rest of the commands. There's no discussion saying it shouldn't have public fields, so I am assuming it was an oversight. This fixes that oversight.