Skip to content

Derive PartialEq for InputFocus #22402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alice-i-cecile merged 1 commit into from
Jan 6, 2026
Merged

Derive PartialEq for InputFocus #22402

alice-i-cecile merged 1 commit into from
Jan 6, 2026

Conversation

@Shatur
Copy link
Contributor

@Shatur Shatur commented Jan 6, 2026

Objective

  • Right now you can't do the the following:
focus.set_if_neq(InputFocus(Some(trigger.entity)));

Solution

  • Derive PartialEq for InputFocus

@Shatur
Derive PartialEq for InputFocus
1f0584a 
Useful to allow the following: ```rust
focus.set_if_neq(InputFocus(Some(trigger.entity))); ```
@Shatur Shatur requested a review from alice-i-cecile January 6, 2026 11:04
@Shatur Shatur added this to the 0.18 milestone Jan 6, 2026
@greeble-dev greeble-dev added C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to get started with Bevy A-Text Rendering and layout for characters S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 6, 2026
@mnmaita mnmaita added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 6, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 6, 2026
Merged via the queue into bevyengine:main with commit c5c5e01 Jan 6, 2026
49 checks passed
cart pushed a commit that referenced this pull request Jan 8, 2026
@Shatur @cart
Derive PartialEq for InputFocus (#22402)
e6cfb69 
# Objective

- Right now you can't do the the following:
```rust
focus.set_if_neq(InputFocus(Some(trigger.entity)));
```

## Solution

- Derive `PartialEq` for `InputFocus`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile Awaiting requested review from alice-i-cecile

2 more reviewers

@it-me-joda it-me-joda it-me-joda approved these changes

@mnmaita mnmaita mnmaita approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Text Rendering and layout for characters C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

0.18

Development

Successfully merging this pull request may close these issues.

5 participants

@Shatur @it-me-joda @mnmaita @alice-i-cecile @greeble-dev