bevy_ui_debug scrollbars inset fix
#22343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace allocated for the scrollbars is no longer in the scrolling area. The UI debug overlay expects the content_insets to include that space and as a result wrongly draws the scrollbars inset into the content box by their width. Solution: Use `ComputedNode`'s `horizontal_scrollbar` and `vertical_scrollbar` methods to position the debug overlay's scroll bar rects instead.
ickshonpe
changed the title
ComputedNode's content_inset field was changed so the sp…bevy_ui_debug scrollbars fix
ickshonpe
added
C-Bug
ickshonpe
changed the title
bevy_ui_debug scrollbars fixbevy_ui_debug scrollbars inset fix
kfc35
approved these changes
Jan 2, 2026
Contributor
kfc35
left a comment
kfc35
left a comment
There was a problem hiding this comment.
logic looks good, also verified via cargo run --example scroll --features=“bevy_ui_debug” that everything looks good on the branch vs main
ickshonpe
added
the
S-Ready-For-Final-Review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
kfc35
removed
the
S-Needs-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
ComputedNode'scontent_insetfield was changed to allocate space for the scrollbars between the content and padding areas. The UI debug overlay expects thecontent_insetsto include that space and as a result wrongly draws the scrollbars inset into the content box by their width.Solution
Use
ComputedNode'shorizontal_scrollbarandvertical_scrollbarmethods to position the debug overlay's scroll bar rects instead.Testing
On main you should see a gap between the the vertical scrollbar and the right edge of the node.
With this PR, the gap should be gone.