Solari: More examples, fix emissive #22295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JMS55
added
C-Bug
JMS55
added
the
S-Needs-Review
SparkyPotato
approved these changes
Dec 29, 2025
ChristopherBiscardi
approved these changes
Dec 29, 2025
Contributor
ChristopherBiscardi
left a comment
ChristopherBiscardi
left a comment
There was a problem hiding this comment.
no dlss:
dlss:
without flag still works
ChristopherBiscardi
added
S-Ready-For-Final-Review
Co-authored-by: Chris Biscardi <[email protected]>
Co-authored-by: Chris Biscardi <[email protected]>
…55/bevy into solari6-example-improvements
IceSentry
approved these changes
Dec 29, 2025
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
* Add a small profiling overlay to the Solari example that times different parts of Solari's GPU work (DLSS-RR not added because wgpu timestamps aren't working correctly with wgpu_hal work, I need to fix that as a separate thing) * Add a many-lights stress test to the Solari example (100 lights) inspired by https://x.com/Roystoncinemo/status/1841917611833229411. Currently somewhat unusable, but this will ideally be a bigger focus for Solari 0.19. * Changed emissive to have exposure applied, as if `emissive_exposure_weight` was always set to 1.0 (StandardMaterial defaults to 0.0 which I'm not convinced is a good idea, but that's a separate topic). If we didn't do this, the emissive meshes would render as insanely bright white to the point of overflowing the texture and breaking DLSS-RR. I think the new behavior is more what people expect to happen, and matches the pathtracer result now. <img width="3206" height="1875" alt="image" src="https://github.com/user-attachments/assets/af3990d6-ae2d-4520-a7cd-f04041685152" /> --------- Co-authored-by: Chris Biscardi <[email protected]> Co-authored-by: Alice Cecile <[email protected]>
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
* Add a small profiling overlay to the Solari example that times different parts of Solari's GPU work (DLSS-RR not added because wgpu timestamps aren't working correctly with wgpu_hal work, I need to fix that as a separate thing) * Add a many-lights stress test to the Solari example (100 lights) inspired by https://x.com/Roystoncinemo/status/1841917611833229411. Currently somewhat unusable, but this will ideally be a bigger focus for Solari 0.19. * Changed emissive to have exposure applied, as if `emissive_exposure_weight` was always set to 1.0 (StandardMaterial defaults to 0.0 which I'm not convinced is a good idea, but that's a separate topic). If we didn't do this, the emissive meshes would render as insanely bright white to the point of overflowing the texture and breaking DLSS-RR. I think the new behavior is more what people expect to happen, and matches the pathtracer result now. <img width="3206" height="1875" alt="image" src="https://github.com/user-attachments/assets/af3990d6-ae2d-4520-a7cd-f04041685152" /> --------- Co-authored-by: Chris Biscardi <[email protected]> Co-authored-by: Alice Cecile <[email protected]>
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
* Add a small profiling overlay to the Solari example that times different parts of Solari's GPU work (DLSS-RR not added because wgpu timestamps aren't working correctly with wgpu_hal work, I need to fix that as a separate thing) * Add a many-lights stress test to the Solari example (100 lights) inspired by https://x.com/Roystoncinemo/status/1841917611833229411. Currently somewhat unusable, but this will ideally be a bigger focus for Solari 0.19. * Changed emissive to have exposure applied, as if `emissive_exposure_weight` was always set to 1.0 (StandardMaterial defaults to 0.0 which I'm not convinced is a good idea, but that's a separate topic). If we didn't do this, the emissive meshes would render as insanely bright white to the point of overflowing the texture and breaking DLSS-RR. I think the new behavior is more what people expect to happen, and matches the pathtracer result now. <img width="3206" height="1875" alt="image" src="https://github.com/user-attachments/assets/af3990d6-ae2d-4520-a7cd-f04041685152" /> --------- Co-authored-by: Chris Biscardi <[email protected]> Co-authored-by: Alice Cecile <[email protected]>
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
* Add a small profiling overlay to the Solari example that times different parts of Solari's GPU work (DLSS-RR not added because wgpu timestamps aren't working correctly with wgpu_hal work, I need to fix that as a separate thing) * Add a many-lights stress test to the Solari example (100 lights) inspired by https://x.com/Roystoncinemo/status/1841917611833229411. Currently somewhat unusable, but this will ideally be a bigger focus for Solari 0.19. * Changed emissive to have exposure applied, as if `emissive_exposure_weight` was always set to 1.0 (StandardMaterial defaults to 0.0 which I'm not convinced is a good idea, but that's a separate topic). If we didn't do this, the emissive meshes would render as insanely bright white to the point of overflowing the texture and breaking DLSS-RR. I think the new behavior is more what people expect to happen, and matches the pathtracer result now. <img width="3206" height="1875" alt="image" src="https://github.com/user-attachments/assets/af3990d6-ae2d-4520-a7cd-f04041685152" /> --------- Co-authored-by: Chris Biscardi <[email protected]> Co-authored-by: Alice Cecile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emissive_exposure_weightwas always set to 1.0 (StandardMaterial defaults to 0.0 which I'm not convinced is a good idea, but that's a separate topic). If we didn't do this, the emissive meshes would render as insanely bright white to the point of overflowing the texture and breaking DLSS-RR. I think the new behavior is more what people expect to happen, and matches the pathtracer result now.