Skip to content

Revert "bug: Fix stackoverflow on asset reload. (#21619)" #22147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alice-i-cecile merged 1 commit into from
Dec 16, 2025
Merged

Revert "bug: Fix stackoverflow on asset reload. (#21619)" #22147

alice-i-cecile merged 1 commit into from
Dec 16, 2025

Conversation

@andriyDev
Copy link
Contributor

@andriyDev andriyDev commented Dec 16, 2025

This reverts commit ac7ee14.

Objective

  • Our CI has been much more flaky with this PR.

Solution

  • Temporarily revert this PR while we investigate the flakes.

Testing

  • Running the asset tests on repeat fairly quickly results in a deadlock with this PR. Without it is much much less likely.

@andriyDev andriyDev added D-Trivial Nice and easy! A great choice to get started with Bevy A-Assets Load files from disk to use for things like images, models, and sounds C-Testing A change that impacts how we test Bevy or how users test their apps S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 16, 2025
@andriyDev andriyDev added this to the 0.18 milestone Dec 16, 2025
@alice-i-cecile
Copy link
Member

alice-i-cecile commented Dec 16, 2025

This PR makes #22135 much better, but doesn't fully resolve the underlying problem.

@alice-i-cecile
Copy link
Member

alice-i-cecile commented Dec 16, 2025

Merging. Sorry @shanecelis; let's take another crack at this later.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 16, 2025
Merged via the queue into bevyengine:main with commit 6ffbb20 Dec 16, 2025
45 checks passed
@andriyDev andriyDev deleted the revert-21619 branch December 16, 2025 05:42
@shanecelis
Copy link
Contributor

shanecelis commented Dec 16, 2025

Thanks for trying, @alice-i-cecile. My heart isn't set on it being merged, so if it falls out of favor, so be it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees

No one assigned

Labels

A-Assets Load files from disk to use for things like images, models, and sounds C-Testing A change that impacts how we test Bevy or how users test their apps D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

None yet

Milestone

0.18

Development

Successfully merging this pull request may close these issues.

3 participants

@andriyDev @alice-i-cecile @shanecelis