Skip to content

reflect rendertarget #22113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alice-i-cecile merged 1 commit into from
Dec 15, 2025
Merged

reflect rendertarget #22113

alice-i-cecile merged 1 commit into from
Dec 15, 2025

Conversation

@ChristopherBiscardi
Copy link
Contributor

@ChristopherBiscardi ChristopherBiscardi commented Dec 15, 2025 •
edited
Loading

RenderTarget was a Component that derived Reflect but did not Reflect Component

as of this merge today: 67633b3

Without this fix, spawning a scene with a camera (such as from a Blender export) causes a panic:

scene contains the unregistered component bevy_camera::camera::RenderTarget. consider adding #[reflect(Component)] to your type

@ChristopherBiscardi ChristopherBiscardi added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Dec 15, 2025
@ChristopherBiscardi ChristopherBiscardi added this to the 0.18 milestone Dec 15, 2025
@ChristopherBiscardi ChristopherBiscardi added the A-Rendering Drawing game state to the screen label Dec 15, 2025
@ChristopherBiscardi ChristopherBiscardi added the D-Trivial Nice and easy! A great choice to get started with Bevy label Dec 15, 2025
tychedelia
tychedelia approved these changes Dec 15, 2025
View reviewed changes
Copy link
Member

@tychedelia tychedelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Thanks for catching this.

@tychedelia tychedelia added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 15, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 15, 2025
Merged via the queue into bevyengine:main with commit ec072d8 Dec 15, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@tychedelia tychedelia tychedelia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: Done

Milestone

0.18

Development

Successfully merging this pull request may close these issues.

3 participants

@ChristopherBiscardi @alice-i-cecile @tychedelia