-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Add support for arbitrary/third party glTF Extension processing via GltfExtensionHandler #22106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alice-i-cecile
merged 27 commits into
bevyengine:main
from
ChristopherBiscardi:gltf-extension-processor
Dec 14, 2025
Merged
Changes from 19 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
d4f44a9
introduce GltfExtensionProcessor
ChristopherBiscardi 9301f85
fix imports for clippy
ChristopherBiscardi 96d67a2
new examples
ChristopherBiscardi f3e9f4d
clippy docs and lints
ChristopherBiscardi 0136191
one more lint
ChristopherBiscardi 7a951b4
one more lint
ChristopherBiscardi ea8d541
Update crates/bevy_gltf/src/lib.rs
ChristopherBiscardi a9e4f12
Update crates/bevy_gltf/src/loader/extensions/mod.rs
ChristopherBiscardi 03b85a0
Update crates/bevy_gltf/src/loader/extensions/mod.rs
ChristopherBiscardi ff3bb56
implement Default instead of insert_resource
ChristopherBiscardi b7c2f8f
fix clippy for gh review commit
ChristopherBiscardi 7a67742
change default extension_ids list to be an empty string
ChristopherBiscardi 14b21e8
change to Handler to avoid AssetProcessor connotations
ChristopherBiscardi 4514b31
cleanup resource push in examples
ChristopherBiscardi 3342b29
clean up extension exports
ChristopherBiscardi 3a4c762
pass extension id alongside data so advanced users can identify which…
ChristopherBiscardi 4ca3f1b
remove dbg
ChristopherBiscardi ad9d4ba
more docs
ChristopherBiscardi 2f1aa7a
publicly
ChristopherBiscardi 1d5d16a
spawn_mesh_and_material is more useful if it accepts all of the gltf …
ChristopherBiscardi 2d137c2
it is more useful to give read access to the relevant gltf node every…
ChristopherBiscardi c55c50a
address some minor feedback
ChristopherBiscardi f45f065
continue, not return, in example loop
ChristopherBiscardi aa6e2dd
use arc+async-lock::rwlock to enable modifying the handlers at runtime
ChristopherBiscardi 5ead859
use labeled_asset instead of loaded_labeled_asset
ChristopherBiscardi ad07efa
alloc
ChristopherBiscardi 5ef8f84
import reorder for clippy
ChristopherBiscardi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.