single query per node in UI picking backend #22049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ickshonpe
added
D-Trivial
pablo-lua
approved these changes
Dec 13, 2025
pablo-lua
added
S-Ready-For-Final-Review
Member
|
@ickshonpe could you resolve merge conflicts please? |
Contributor
Author
|
@alice-i-cecile should be good now |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The UI picking backend queries twice for the node data. Simplify
ui_pickingby storing the camera entity and picking data inhit_nodesinstead of the second query.Solution
Store the camera entity and picking data in
hit_nodesinstead of querying for them again.