Skip to content

remove unnecessary clone from load_font_to_fontdb #22009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
james7132 merged 1 commit into from
Dec 2, 2025
Merged

remove unnecessary clone from load_font_to_fontdb #22009

james7132 merged 1 commit into from
Dec 2, 2025

Conversation

@ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Dec 2, 2025

Objective

load_font_to_fontdb clones the font handle needlessly.

Solution

Just call id() on it.

@james7132 james7132 added D-Trivial Nice and easy! A great choice to get started with Bevy C-Performance A change motivated by improving speed, memory usage or compile times A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change labels Dec 2, 2025
@james7132 james7132 enabled auto-merge December 2, 2025 16:52
@james7132 james7132 added this pull request to the merge queue Dec 2, 2025
@ickshonpe ickshonpe added A-Text Rendering and layout for characters and removed A-UI Graphical user interfaces, styles, layouts, and widgets labels Dec 2, 2025
@dloukadakis dloukadakis added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Dec 2, 2025
Merged via the queue into bevyengine:main with commit 243d562 Dec 2, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@james7132 james7132 james7132 approved these changes

+1 more reviewer

@dloukadakis dloukadakis dloukadakis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Text Rendering and layout for characters C-Code-Quality A section of code that is hard to understand or change C-Performance A change motivated by improving speed, memory usage or compile times D-Trivial Nice and easy! A great choice to get started with Bevy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ickshonpe @james7132 @dloukadakis