Skip to content

UI text module refactor #21630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cart merged 6 commits into from
Dec 2, 2025
Merged

UI text module refactor #21630

cart merged 6 commits into from
Dec 2, 2025

Conversation

@ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Oct 22, 2025 •
edited
Loading

Objective

The measure_text_system and text_system systems don't do anything except iterate a query and then delegate to two other functions, create_text_measure and queue_text, respectively. This doesn't serve any purpose and just makes these systems harder to understand.

Solution

Flatten the module by moving the code from create_text_measure and queue_text into the systems and remove those functions.

@ickshonpe ickshonpe added D-Trivial Nice and easy! A great choice to get started with Bevy A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change A-Text Rendering and layout for characters S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 22, 2025
@ickshonpe ickshonpe mentioned this pull request Oct 28, 2025
Open
rossleonardy
rossleonardy approved these changes Nov 12, 2025
View reviewed changes
Copy link
Contributor

@rossleonardy rossleonardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

@ickshonpe ickshonpe added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 28, 2025
@cart cart added this pull request to the merge queue Dec 2, 2025
Merged via the queue into bevyengine:main with commit a06de1f Dec 2, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cart cart cart approved these changes

+2 more reviewers

@rossleonardy rossleonardy rossleonardy approved these changes

@DaAlbrecht DaAlbrecht DaAlbrecht approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Text Rendering and layout for characters A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ickshonpe @cart @rossleonardy @DaAlbrecht