Modify stub handling to allow for console and GUI stubs#48
Merged
Conversation
10 tasks
4 tasks
Member
Author
|
I've now pushed updated binaries for the console and GUI stubs; this should be ready for final testing. |
mhsmith
approved these changes
Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies the stub handling so that there are 2 binary stubs - one for GUI, and one for console.
The post-processing step moves the correct binary to the
Stubname (rather than<Formal Name>), and deletes the unneeded binaries. TheStubname is used as part of a fix for beeware/briefcase#1729.This PR cannot be completed until beeware/briefcase-windows-VisualStudio-template#29 is completed, as the new app binaries need to be generated using the new VisualStudio template.
Refs beeware/briefcase#1781
Briefcase-Repo: https://github.com/freakboy3742/briefcase.git
Briefcase-Ref: cmdline-app
PR Checklist: