Skip to content

OperationConditionalCreateToManyWithReverseRelation convert operation fixed#90

Merged
christianbumann merged 3 commits intobbtsoftware:developfrom
stefan-lindegger:feature/GH-89
Aug 30, 2021
Merged

OperationConditionalCreateToManyWithReverseRelation convert operation fixed#90
christianbumann merged 3 commits intobbtsoftware:developfrom
stefan-lindegger:feature/GH-89

Conversation

@stefan-lindegger
Copy link
Member

@stefan-lindegger stefan-lindegger commented Aug 27, 2021

Fixes #89.
OperationConditionalCreateToManyWithReverseRelation convert operation fixed - filter for duplicate entries.
Tests and fest data enhanced (scenarios for handling of composition with list properties added)

@stefan-lindegger stefan-lindegger requested review from a team as code owners August 27, 2021 07:47
@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #90 (67c4188) into develop (f833a24) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 67c4188 differs from pull request most recent head b43ec25. Consider uploading reports for the commit b43ec25 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #90      +/-   ##
===========================================
+ Coverage    80.03%   80.07%   +0.04%     
===========================================
  Files          105      105              
  Lines         1983     1987       +4     
  Branches       142      142              
===========================================
+ Hits          1587     1591       +4     
  Misses         335      335              
  Partials        61       61              
Impacted Files Coverage Δ
...ationConditionalCreateToManyWithReverseRelation.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f833a24...b43ec25. Read the comment docs.

… fixed - filter for duplicate entries

Tests and fest data enhanced (scenarios for handling of composition with list properties added)
@christianbumann christianbumann merged commit 240eb94 into bbtsoftware:develop Aug 30, 2021
@christianbumann christianbumann added this to the 1.0.1 milestone Aug 30, 2021
@christianbumann christianbumann added the Bug Something isn't working label Aug 30, 2021
@christianbumann christianbumann changed the title Fixes #89 OperationConditionalCreateToManyWithReverseRelation convert operation fixed Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Development

Successfully merging this pull request may close these issues.

While adding, OperationConditionalCreateToManyWithReverseRelation does not check if element is already added

2 participants