fix: Do not add coursier opts when run other tools#1531
Conversation
honnix
force-pushed
the
honnix/fix-java-opts
branch
from
2aa216c to
efa1c3b
Compare
honnix
force-pushed
the
honnix/fix-java-opts
branch
from
efa1c3b to
89b7bd9
Compare
| java_path = _java_path(repository_ctx) | ||
|
|
||
| if java_path != None: | ||
| cmd = [java_path, "-jar"] + _get_java_proxy_args(repository_ctx) + [jar_path] |
There was a problem hiding this comment.
I'm not sure -noverify is still needed as it has been deprecated since Java 13.
OpenJDK 64-Bit Server VM warning: Options -Xverify:none and -noverify were deprecated in JDK 13 and will likely be removed in a future release.
There was a problem hiding this comment.
We're an old project, so it's likely this is left over from the early days. However, we do want to continue to support Java 11 onwards, so we should only remove this flag if it won't compromise our ability to run there.
shs96c
left a comment
shs96c
left a comment
There was a problem hiding this comment.
LGTM. Thank you for the PR
| java_path = _java_path(repository_ctx) | ||
|
|
||
| if java_path != None: | ||
| cmd = [java_path, "-jar"] + _get_java_proxy_args(repository_ctx) + [jar_path] |
There was a problem hiding this comment.
We're an old project, so it's likely this is left over from the early days. However, we do want to continue to support Java 11 onwards, so we should only remove this flag if it won't compromise our ability to run there.
* master: Add presubmit check for prebuilt jars (bazel-contrib#1486) Upload artifacts in parallel (address artifactorys "Maven Snapshot Version Behaviour") (bazel-contrib#1524) feat: Support COURSIER_SHA256 environment variable (bazel-contrib#1527) fix: Do not add coursier opts when run other tools (bazel-contrib#1531) fix: add string attributes to `amend_artifact` for explicit unset state (bazel-contrib#1499) fix: use forward slash separator in Maven purl format (bazel-contrib#1530) Load rules from specific bzl files and add sh_test imports (bazel-contrib#1529) Added non-conflicting hash for install files (bazel-contrib#1454) Update the maven and coursier resolver tests to create a class index file. (bazel-contrib#1519) [ci] Drop Bazel 6 and ensure we run on Bazel 7 and 8 (bazel-contrib#1525) Only allow modules specified in known_contributing_modules to contribute artifacts or boms to the root module (bazel-contrib#1523) [gradle] Fix false resolution failures when BOM upgrades dependency version (bazel-contrib#1520)
2 participants
_generate_java_jar_commandis used in a few other places than callingcoursier, so addingCOURSIER_OPTSdoesn't make sense.