Add presubmit check for prebuilt jars#1486
Merged
Merged
Conversation
shs96c
approved these changes
Dec 5, 2025
Collaborator
|
I love this. There's a handful of PRs that are currently in flight. It seems unfair to ask them to run more steps, so once those land, I'll merge this. |
This was referenced Jan 10, 2026
shs96c
added a commit
to shs96c/rules_jvm_external
that referenced
this pull request
Feb 3, 2026
* master: Add presubmit check for prebuilt jars (bazel-contrib#1486) Upload artifacts in parallel (address artifactorys "Maven Snapshot Version Behaviour") (bazel-contrib#1524) feat: Support COURSIER_SHA256 environment variable (bazel-contrib#1527) fix: Do not add coursier opts when run other tools (bazel-contrib#1531) fix: add string attributes to `amend_artifact` for explicit unset state (bazel-contrib#1499) fix: use forward slash separator in Maven purl format (bazel-contrib#1530) Load rules from specific bzl files and add sh_test imports (bazel-contrib#1529) Added non-conflicting hash for install files (bazel-contrib#1454) Update the maven and coursier resolver tests to create a class index file. (bazel-contrib#1519) [ci] Drop Bazel 6 and ensure we run on Bazel 7 and 8 (bazel-contrib#1525) Only allow modules specified in known_contributing_modules to contribute artifacts or boms to the root module (bazel-contrib#1523) [gradle] Fix false resolution failures when BOM upgrades dependency version (bazel-contrib#1520)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add presubmit check to ensure prebuilt jars are updated in the same PR where their sources change. This will prevent issues like this one, as well as: