Add support for resources in javadoc jars and make variable substitution in javadoc arguments#1238
Merged
shs96c merged 10 commits intoSep 9, 2024
Conversation
…ble substitution in javadoc arguments.
shs96c
requested changes
Sep 9, 2024
Collaborator
shs96c
left a comment
There was a problem hiding this comment.
Two small nits, and then I'll merge. Thank you for re-opening!
Contributor
Author
|
@shs96c Made the suggested changes, this is ready for another review. Thanks! |
shs96c
approved these changes
Sep 9, 2024
Collaborator
shs96c
left a comment
There was a problem hiding this comment.
LGTM. Thank you for making the changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This is a dupe of #1182 . I had to reopen the PR from a different GH org.
There's two use cases I'm trying to account for here.
LICENSEfile.--definevariable to the javadoc generator so that themaven_versionvariable I have set will appear in the<title>of the generated html. rules_jvm_external already supports the same type of substitution on thecoordinatesattribute.