Add support for resources in javadoc jars and make variable substitution in javadoc arguments#1182
Closed
vinnybod wants to merge 3 commits into
Closed
Conversation
…ble substitution in javadoc arguments.
Contributor
Author
|
The CI failures seems unrelated. |
shs96c
reviewed
Sep 7, 2024
Collaborator
shs96c
left a comment
There was a problem hiding this comment.
LGTM. The GH UI is telling me that this has merge conflicts. Once those are resolved, I'll merge. Thank you for the PR!
|
|
||
| import static java.nio.charset.StandardCharsets.UTF_8; | ||
|
|
||
| public class JarUtils { |
Collaborator
There was a problem hiding this comment.
Strictly speaking, these a ZipUtils, but that's nit picking.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's two use cases I'm trying to account for here.
LICENSEfile.--definevariable to the javadoc generator so that themaven_versionvariable I have set will appear in the<title>of the generated html. rules_jvm_external already supports the same type of substitution on thecoordinatesattribute.