Skip to content
This repository was archived by the owner on Jan 3, 2023. It is now read-only.

Fix BFN syncd-rpc compilation#33

Closed
msosyak wants to merge 2 commits intomasterfrom
saithriftv2
Closed

Fix BFN syncd-rpc compilation#33
msosyak wants to merge 2 commits intomasterfrom
saithriftv2

Conversation

@msosyak
Copy link
Copy Markdown

@msosyak msosyak commented Sep 9, 2021

- What I did

  • Fix BFN syncd-rpc compilation
  • Enable saithriftv2 for BFN syncd-rpc
  • Add docker ptf under bfn platfrom with needed dependencies

- How I did it
Fix rules

- How to verify it
This PR relay on barefootnetworks/SAI#2

NOJESSIE=1 NOSTRETCH=1 make configure platform=barefoot
ENABLE_SYNCD_RPC=y NOJESSIE=1 NOSTRETCH=1 make target/docker-syncd-bfn-rpc.gz
 
ENABLE_SYNCD_RPC=y NOJESSIE=1 NOSTRETCH=1 make target/docker-ptf.gz

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a dependency on thrift 0.13 for the SAI PTF?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, thrift 0.13.0 is backward compatible with 0.11.0 in almost all cases, but the original thrift target is built with an additional option -DFORCE_BOOST_SMART_PTR . This causes issues for BFN SDE as we use thrift in driver, platform, and also, in SAIv2 rpc server and everywhere with std::smart_ptr. To fix those issues I have added thrift_0_13_0 target to sonic-buildimage recently sonic-net#8307. That is why LIBSAITHRIFT_DEV depends on LIBTHRIFT_0_13_0

UPD: -DFORCE_BOOST_SMART_PTR was removed in thrift 0.13.0 and std::smart_ptr is used by default.

@akokhan akokhan force-pushed the saithriftv2 branch 2 times, most recently from cfe019f to ae93d56 Compare September 13, 2021 15:47
@msosyak msosyak changed the title Add SAITHRIFTV2 option to build syncd-rpc with saithriftv2 Fix BFN syncd-rpc compilation Sep 13, 2021
@msosyak
Copy link
Copy Markdown
Author

msosyak commented Mar 29, 2022

Closed in favor of sonic-net#9884

@msosyak msosyak closed this Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants