This repository was archived by the owner on Jan 3, 2023. It is now read-only.
Closed
Conversation
akokhan
reviewed
Sep 10, 2021
7c5d150 to
1609d56
Compare
ravi861
reviewed
Sep 10, 2021
There was a problem hiding this comment.
Is there a dependency on thrift 0.13 for the SAI PTF?
Author
There was a problem hiding this comment.
Actually, thrift 0.13.0 is backward compatible with 0.11.0 in almost all cases, but the original thrift target is built with an additional option -DFORCE_BOOST_SMART_PTR . This causes issues for BFN SDE as we use thrift in driver, platform, and also, in SAIv2 rpc server and everywhere with std::smart_ptr. To fix those issues I have added thrift_0_13_0 target to sonic-buildimage recently sonic-net#8307. That is why LIBSAITHRIFT_DEV depends on LIBTHRIFT_0_13_0
UPD: -DFORCE_BOOST_SMART_PTR was removed in thrift 0.13.0 and std::smart_ptr is used by default.
ravi861
reviewed
Sep 10, 2021
cfe019f to
ae93d56
Compare
ae93d56 to
15ac999
Compare
Author
|
Closed in favor of sonic-net#9884 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
Fix rules
- How to verify it
This PR relay on barefootnetworks/SAI#2
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)