Skip to content

Add Saithriftv2 rpc server #2

Closed
msosyak wants to merge 2 commits intosaithriftv2-basefrom
saithriftv2
Closed

Add Saithriftv2 rpc server #2
msosyak wants to merge 2 commits intosaithriftv2-basefrom
saithriftv2

Conversation

@msosyak
Copy link
Copy Markdown

@msosyak msosyak commented Sep 9, 2021 •
edited
Loading

@msosyak msosyak mentioned this pull request Sep 9, 2021
Closed
@msosyak msosyak requested a review from ravi861 September 10, 2021 14:10
@ravi861
Copy link
Copy Markdown

ravi861 commented Sep 10, 2021

Can we remove all the PERL code and templates? We should only have a patch with the generated RPC file and the frontend CPP file.

@msosyak msosyak changed the base branch from master to saithriftv2-base September 13, 2021 16:03
@msosyak
Copy link
Copy Markdown
Author

msosyak commented Sep 13, 2021

Can we remove all the PERL code and templates? We should only have a patch with the generated RPC file and the frontend CPP file.

Yes, I have removed it. But what is the idea? I thought it is like a feature of a new RPC server.

@ravi861
Copy link
Copy Markdown

ravi861 commented Sep 13, 2021

Can we remove all the PERL code and templates? We should only have a patch with the generated RPC file and the frontend CPP file.

Yes, I have removed it. But what is the idea? I thought it is like a feature of a new RPC server.

We will eventually have to come up with how to regenerate these RPC servers everytime something changes in SAI. For now, we can just checkin the generated source for MSFT.

@msosyak msosyak closed this Mar 29, 2022
@msosyak
Copy link
Copy Markdown
Author

msosyak commented Mar 29, 2022

Closed in favor of opencomputeproject#1388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ravi861 ravi861 Awaiting requested review from ravi861

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@msosyak @ravi861