Skip to content

Add more info to error messages when using min/max as column names #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rachaelshaw merged 3 commits into from
Apr 30, 2019
Merged

Add more info to error messages when using min/max as column names #1600

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ee5c84
Add more info to error messages when using min/max as column names
Apr 26, 2019
a9f6cb4
Move language about min/max as column name underneath the example
rachaelshaw Apr 30, 2019
18ff235
Add the same info to the error messages for `sum`, `average` and `gro…
rachaelshaw Apr 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/waterline/utils/query/private/normalize-criteria.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,9 @@ module.exports = function normalizeCriteria(criteria, modelIdentity, orm, meta)
'usage has changed. Now, to calculate the minimum value of an attribute '+
'across multiple records, use the `.find()` model method.\n'+
'\n'+
'Alternatively, if you are using `min` as a column/attribute name then '+
'please be advised that some things won\'t work as expected.\n'+
'\n'+
'For example:\n'+
'```\n'+
'// Get the smallest account balance from amongst all account holders '+'\n'+
Expand Down Expand Up @@ -335,6 +338,9 @@ module.exports = function normalizeCriteria(criteria, modelIdentity, orm, meta)
'usage has changed. Now, to calculate the maximum value of an attribute '+
'across multiple records, use the `.find()` model method.\n'+
'\n'+
'Alternatively, if you are using `max` as a column/attribute name then '+
'please be advised that some things won\'t work as expected.\n'+
'\n'+
'For example:\n'+
'```\n'+
'// Get the largest account balance from amongst all account holders '+'\n'+
Expand Down