Skip to content

Add more info to error messages when using min/max as column names#1600

Merged
rachaelshaw merged 3 commits intobalderdashy:masterfrom
alxndrsn:min-max-error-clarification
Apr 30, 2019
Merged

Add more info to error messages when using min/max as column names#1600
rachaelshaw merged 3 commits intobalderdashy:masterfrom
alxndrsn:min-max-error-clarification

Conversation

@alxndrsn
Copy link

No description provided.

@rachaelshaw
Copy link
Member

@alxndrsn Thanks for helping improve these error messages! I went ahead and made a couple changes before merging:
• Moved the additional text below the example code in the error messages, just so people don't get confused about what the example is demonstrating (i.e. so they don't assume it's an example of things not working as expected)
• Added the same message for groupBy, sum, and average, since those have the same problem

@rachaelshaw rachaelshaw merged commit f1fd3f8 into balderdashy:master Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants