Skip to content

[patch] check for NaN and inifinte values when coercing to integer #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BrownBear2 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[patch] check for NaN and inifinte values when coercing to integer #1351

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8db008a
check for NaN and inifinte values when coercing to integer
BrownBear2 May 10, 2016
9c694ad
typo
BrownBear2 May 10, 2016
21457ba
curlies
BrownBear2 Feb 9, 2017
409a89e
less spaces ^_^
BrownBear2 Feb 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/waterline/utils/normalize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,11 @@ module.exports = {
}

if (context.attributes[pk].type == 'integer') {
coercePK = function(pk) {return +pk;};
coercePK = function(pk) {
var val = +pk;
if (isNaN(val) || !isFinite(val)) val = 0;
return val;
};
} else if (context.attributes[pk].type == 'string') {
coercePK = function(pk) {return String(pk).toString();};

Expand Down