[patch] check for NaN and inifinte values when coercing to integer#1351
Open
BrownBear2 wants to merge 4 commits intobalderdashy:masterfrom
Open
[patch] check for NaN and inifinte values when coercing to integer#1351BrownBear2 wants to merge 4 commits intobalderdashy:masterfrom
BrownBear2 wants to merge 4 commits intobalderdashy:masterfrom
Conversation
|
Hi @BrownBear2! It looks like your pull request title doesn’t quite conform to our guidelines. Please edit the title so that it starts with [proposal], [patch], [fixes #], or [implements #]. Once you've fixed it, post a comment below (e.g. "ok, fixed!") and we'll take a look! |
BrownBear2
changed the title
Author
|
ok, fixed! |
mikermcneil
requested changes
Dec 7, 2016
mikermcneil
approved these changes
Dec 7, 2016
mikermcneil
requested changes
Dec 7, 2016
Member
mikermcneil
left a comment
mikermcneil
left a comment
There was a problem hiding this comment.
@BrownBear2 So I think all that's left is a test, if you'd be so kind.
BrownBear2
added a commit
to BrownBear2/waterline
that referenced
this pull request
Feb 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see balderdashy/sails#3705