Fix incorrect CodeBuild build/deploy references in params #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Issue: ** awslabs#488. **What:** Updated references and made sure line length would not exceed the maximum on the lines that were changed.
StewartW
previously approved these changes
Aug 17, 2022
**Why?** At the moment, if you would set privilege to `True` on the default deploy provider properties and try to override those to `False` in a specific target, it will still have privilege enabled. **What?** Updated the logic to only override if it was not specified, not when it is `False`.
Collaborator
Author
|
I found another issue while looking at the code once more. Fix CodeBuild privilege override with target parameters Why? At the moment, if you would set privilege to What? Updated the logic to only override if it was not specified, not when it is |
StewartW
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #488.
What?
Updated references and made sure line length would not exceed the maximum on
the lines that were changed.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.