Skip to content

Commit 1688339

Browse files
committed
Fix CodeBuild privilege override with target parameters
**Why?** At the moment, if you would set privilege to `True` on the default deploy provider properties and try to override those to `False` in a specific target, it will still have privilege enabled. **What?** Updated the logic to only override if it was not specified, not when it is `False`.
1 parent 2568d32 commit 1688339

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

  • src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs

src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codebuild.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,10 @@ def __init__(self, scope: core.Construct, id: str, shared_modules_bucket: str, d
4848
'properties', {}).get(
4949
'size', "SMALL").upper()),
5050
environment_variables=CodeBuild.generate_build_env_variables(_codebuild, shared_modules_bucket, map_params, target),
51-
privileged=(
52-
target.get('properties', {}).get('privileged', False)
53-
or map_params['default_providers']['deploy'].get(
54-
'properties', {}).get('privileged', False)
51+
privileged=target.get('properties', {}).get(
52+
'privileged',
53+
map_params['default_providers']['deploy'].get(
54+
'properties', {}).get('privileged', False),
5555
)
5656
)
5757
build_spec = CodeBuild.determine_build_spec(

0 commit comments

Comments
 (0)