Skip to content

Allow use timeout and environment_variables in codebuild deploy stage #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbkok merged 2 commits into from
Feb 16, 2021
Merged

Allow use timeout and environment_variables in codebuild deploy stage #307

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec8c0ab
Allow update timeout when being used in the deploy stage within codep…
Dec 1, 2020
8059a76
Merge branch 'master' into master
yvthepief Feb 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .../initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codebuild.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def __init__(self, scope: core.Construct, id: str, shared_modules_bucket: str, d
ADF_DEPLOYMENT_ACCOUNT_ID,
target.get('properties', {}).get('role')
) if target.get('properties', {}).get('role') else ADF_DEFAULT_BUILD_ROLE
_timeout = target.get('properties', {}).get('timeout') or ADF_DEFAULT_BUILD_TIMEOUT
_timeout = target.get('properties', {}).get('timeout') or map_params['default_providers']['deploy'].get('properties', {}).get('timeout') or ADF_DEFAULT_BUILD_TIMEOUT
_env = _codebuild.BuildEnvironment(
build_image=CodeBuild.determine_build_image(scope, target, map_params),
compute_type=target.get(
Expand Down Expand Up @@ -200,6 +200,10 @@ def generate_build_env_variables(codebuild, shared_modules_bucket, map_params, t
for _env_var in _build_env_vars.items():
_output[_env_var[0]] = codebuild.BuildEnvironmentVariable(value=str(_env_var[1]))
if target:
_deploy_env_vars = map_params.get('default_providers', {}).get('deploy', {}).get('properties', {}).get('environment_variables', {})
for _env_var in _deploy_env_vars.items():
_output[_env_var[0]] = codebuild.BuildEnvironmentVariable(value=str(_env_var[1]))

_target_env_vars = target.get('properties', {}).get('environment_variables', {})
for _target_env_var in _target_env_vars.items():
_output[_target_env_var[0]] = codebuild.BuildEnvironmentVariable(value=_target_env_var[1])
Expand Down