Allow use timeout and environment_variables in codebuild deploy stage #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ipeline, Allow read of environment_variables when using codebuild in the deployment stage in codepipeline
sbkok
approved these changes
Dec 30, 2020
Collaborator
sbkok
left a comment
sbkok
left a comment
There was a problem hiding this comment.
Thanks for contributing these fixes!
Looks good to me.
Collaborator
|
Hi @yvthepief, could you rebase your changes on top of the latest master commit? |
Contributor
Author
Done! |
thomasmcgannon
approved these changes
Feb 16, 2021
Collaborator
thomasmcgannon
left a comment
thomasmcgannon
left a comment
There was a problem hiding this comment.
Looks good to me!
sbkok
added a commit
to sbkok/aws-deployment-framework
that referenced
this pull request
Mar 3, 2021
**Fixes 🐞** * Fixes `timeout` and `environment_variables` to be used when defined in the default CodeBuild Deployment provider properties awslabs#307, closes awslabs#306. * Fixes intrinsic functions for account_region param files awslabs#333, closes awslabs#147. * Fixes use of deployment from source directly when build stage is disabled awslabs#334, closes awslabs#236 and closes awslabs#318.
Merged
sbkok
added a commit
that referenced
this pull request
Mar 3, 2021
**Fixes 🐞** * Fixes `timeout` and `environment_variables` to be used when defined in the default CodeBuild Deployment provider properties #307, closes #306. * Fixes intrinsic functions for account_region param files #333, closes #147. * Fixes use of deployment from source directly when build stage is disabled #334, closes #236 and closes #318.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow update timeout when being used in the deploy stage within codepipeline, Allow read of environment_variables when using codebuild in the deployment stage in codepipeline
Issue #, if available:
#306
Description of changes:
Added the possibility to set timeout and environment_variables when using CodeBuild in the deployment stage of CodePipeline.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.