Fix CodeBuild provider spec_inline support #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What was the problem?** 1. The `spec_inline` property was documented and type checked as a string. Whereas the CDK function used to include the `spec_inline` expects an object instead. 2. If CodeBuild was used as a deployment provider, it would not be able to use the `spec_inline`. Nor would you be able to specify `spec_inline` as part of a target definition. Even though the schema validation made it look like it would support `spec_inline`. **What has been changed?** * Updates the schema validation to support objects, as required by the CDK BuildSpec construct. * Changes the CodeBuild provider for deployment and build stages, such that both support inline and file reference usage of BuildSpec definitions. * When both the `spec_inline` and `spec_filename` properties are defined as part of the default provider or target properties, an error message will be thrown. * Tests have been added to verify that the added method works as intended.
sbkok
force-pushed
the
fix/codebuild_spec_inline
branch
from
f5f50cb to
66c1d56
Compare
sbkok
added a commit
to sbkok/aws-deployment-framework
that referenced
this pull request
Feb 12, 2021
**Features 🏗** * Adds Enterprise Support to account creation process awslabs#233, closes awslabs#232: * ADF will raise a ticket to add the account to an existing AWS support subscription when an account is created. As a prerequisite, your organization master account must already have enterprise support activated. * Adds nested deployment map support awslabs#266 and awslabs#328, closes awslabs#265: * This enables usage of sub directories within the deployment_maps folder. **Fixes 🐞** * Fixes specific role usage to be used in Build and Deploy only awslabs#295. * Corrects removing pipelines anchor in docs awslabs#279. * Fixes CI builds due to isort version mismatch awslabs#284. * Fixes error handling of generate_params intrinsic upload function awslabs#277, closes awslabs#276. * Fixes spec_inline attribute of CodeBuild in docs awslabs#289. * Fixes provider spec_inline support of CodeBuild in awslabs#293. * Fixes supported list of intrinsic upload path styles, enables usage of s3-url and s3-key-only awslabs#275, closes awslabs#299. * Fixes create deployment account concurrency failure awslabs#287, closes awslabs#280. * Fixes approval stage usage, by limiting specific role usage to Build and Deploy steps awslabs#295. * Fixes yarnpkg GPG awslabs#313, closes awslabs#325. * Removes dependency on botocore.vendored.requests awslabs#326, closes awslabs#324. **Improvements ✨** * Improves docs on providers and their properties awslabs#274. * Separates pipeline cleanup from input generation script awslabs#288. * Upgrades Python from v3.7 to v3.8 awslabs#313. * Upgrades CodeBuild image from "aws/codebuild/standard:2.0" to "aws/codebuild/standard:5.0" awslabs#313, closes awslabs#267, closes awslabs#300. * Upgrades CDK from v1.32 to v1.88 awslabs#313, closes awslabs#292.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
The
spec_inlineproperty was documented and type checked as a string.Whereas the CDK function used to include the
spec_inlineexpects anobject instead.
If CodeBuild was used as a deployment provider, it would not be able
to use the
spec_inline. Nor would you be able to specifyspec_inlineas part of a target definition. Even though the schemavalidation made it look like it would support
spec_inline.What has been changed?
by the CDK BuildSpec construct.
both support inline and file reference usage of BuildSpec definitions.
spec_inlineandspec_filenameproperties are defined aspart of the default provider or target properties, an error message will be
thrown.
intended.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.