Skip to content

Support paginator for parameters and empty descriptions in moved to root lambda #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbkok merged 9 commits into from
May 25, 2021
Merged

Support paginator for parameters and empty descriptions in moved to root lambda #273

Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b45f17f
add-ssm-paginator-to-moved-to-root
rickardl Jun 8, 2020
04075df
fix: parameter name key
rickardl Jun 8, 2020
e664e72
fix: use get in parameter
rickardl Jun 8, 2020
84b973b
Merge branch 'master' into add-ssm-paginator-to-moved-to-ou-lambda
rickardl Jun 11, 2020
a9c010a
Merge branch 'master' into add-ssm-paginator-to-moved-to-ou-lambda
rickardl Jul 24, 2020
b14a106
Merge branch 'master' into add-ssm-paginator-to-moved-to-ou-lambda
rickardl Oct 12, 2020
3bd0e0c
fix: replace helper method with boto3 paginator
rickardl May 13, 2021
113dc6d
Merge branch 'master' into add-ssm-paginator-to-moved-to-ou-lambda
rickardl May 13, 2021
beb8209
Merge branch 'master' into add-ssm-paginator-to-moved-to-ou-lambda
sbkok May 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/lambda_codebase/moved_to_root.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from parameter_store import ParameterStore
from logger import configure_logger
from cloudformation import CloudFormation
from paginator import paginator

LOGGER = configure_logger(__name__)
REGION_DEFAULT = os.environ.get('AWS_REGION')
Expand All @@ -28,9 +29,10 @@ def worker_thread(sts, region, account_id, role, event):
'remove_base')

parameter_store = ParameterStore(region, role)
parameters = [param['Name'] for param in parameter_store.client.describe_parameters()['Parameters'] if 'Used by The AWS Deployment Framework' in param['Description']]
for parameter in parameters:
parameter_store.delete_parameter(parameter)
for page in paginator(parameter_store.client.describe_parameters):
Copy link
Collaborator

@sbkok sbkok Apr 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please change this to use the Boto3 paginator instead?
See the docs in boto3 here: https://boto3.amazonaws.com/v1/documentation/api/latest/guide/paginators.html

Copy link
Contributor Author

@rickardl rickardl Apr 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely, I'll update the PR next week!

for parameter in page['Parameters']:
if 'Used by The AWS Deployment Framework' in parameter.get('Description', ''):
parameter_store.delete_parameter(parameter.get('Name'))

cloudformation = CloudFormation(
region=region,
Expand Down