Support paginator for parameters and empty descriptions in moved to root lambda #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickardl
changed the title
sbkok
requested changes
Apr 9, 2021
src/lambda_codebase/moved_to_root.py
Outdated
| parameters = [param['Name'] for param in parameter_store.client.describe_parameters()['Parameters'] if 'Used by The AWS Deployment Framework' in param['Description']] | ||
| for parameter in parameters: | ||
| parameter_store.delete_parameter(parameter) | ||
| for page in paginator(parameter_store.client.describe_parameters): |
Collaborator
There was a problem hiding this comment.
Could you please change this to use the Boto3 paginator instead?
See the docs in boto3 here: https://boto3.amazonaws.com/v1/documentation/api/latest/guide/paginators.html
Contributor
Author
There was a problem hiding this comment.
Absolutely, I'll update the PR next week!
sbkok
approved these changes
May 21, 2021
Collaborator
sbkok
left a comment
sbkok
left a comment
There was a problem hiding this comment.
Thanks for updating the pull request and contributing this fix.
Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The below change hopefully resolves all issues we encountered in #272