Skip to content

feat(jsii-pacmak): parsing arguments in non-strict mode #4068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Apr 26, 2023
Merged

feat(jsii-pacmak): parsing arguments in non-strict mode #4068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a3db38
feat(jsii-pacmak): parsing arguments in non-strict mode
Apr 24, 2023
30ea63b
Merge branch 'main' into main
mergify[bot] Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/jsii-pacmak/bin/jsii-pacmak.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,7 @@ import { VERSION_DESC } from '../lib/version';
desc: 'Whether jsii assemblies should be validated. This can be expensive and is skipped by default.',
default: false,
})
.version(VERSION_DESC)
.strict().argv;
.version(VERSION_DESC).argv;

configureLogging({ level: argv.verbose !== undefined ? argv.verbose : 0 });

Expand Down
7 changes: 6 additions & 1 deletion packages/jsii-pacmak/test/build-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,4 +85,9 @@ ${pacmak} ${OPTS} -v --no-parallel $packagedirs
# Test custom pack command
clean_dists
echo "Testing yarn custom pack command."
${pacmak} ${OPTS} -v --pack-command='yarn pack -f custom.tgz -s && echo custom.tgz' ${PWD}/../../@scope/jsii-calc-base-of-base
${pacmak} ${OPTS} -v --pack-command='yarn pack -f custom.tgz -s && echo custom.tgz' ${PWD}/../../@scope/jsii-calc-base-of-base

# Test custom mvn settings command
clean_dists
echo "Testing custom mvn parameters."
${pacmak} ${OPTS} -v --mvn-builder=singlethreaded --mvn-threads=4 $packagedirs