feat(jsii-pacmak): parsing arguments in non-strict mode #4068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some targets support extra target-specific arguments so users can customize the behavior of the build tools. For example, the Java target allows users to customize the `mvn` CLI behaviour with `--mvn-*` parameters. However the `jsi--pacmak` CLI is blocking this feature because it is using strict mode when parsing argument. This change lifts that gate.
RomainMuller
approved these changes
Apr 26, 2023
Contributor
RomainMuller
left a comment
RomainMuller
left a comment
There was a problem hiding this comment.
This has the drawback of silently accepting typo'd flags and arguments, which is a little unfortunate... But I guess the feature is worth the trade-off here...
Contributor
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Contributor
|
Merging (with squash)... |
Contributor
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some targets support extra target-specific arguments so users can customize the behavior of the build tools. For example, the Java target allows users to customize the
mvnCLI behaviour with--mvn-*parameters. However thejsi-pacmakCLI is blocking this feature because it is using strict mode when parsing arguments. This change lifts that gate.This address #3465
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.