Fix QuickStart example #1 warnings#1717
Merged
awood45 merged 31 commits intoaws:masterfrom Mar 12, 2018
Merged
Conversation
Fixes the following warning when run under -w:
aws-sdk-core-3.16.0/lib/seahorse/model/shapes.rb:39:
warning: instance variable @location not initialized
Fixes the following warning when run under -w:
aws-sdk-core-3.16.0/lib/aws-sdk-core/rest/request/endpoint.rb:52:
warning: shadowing outer local variable - parts
Fixes the following warning when run under -w:
aws-sigv4-1.0.2/lib/aws-sigv4/signer.rb:441:
warning: shadowing outer local variable - headers
Contributor
Author
|
The TravisCI test failure is on JRuby 9.1.5.0 only. My changes pass on all other Rubies. I am not able to reproduce the error on JRuby 9.1.16.0. I wonder if the problem is with JRuby 9.1.5.0 (and has since been fixed in 9.1.16.0)? The error relates to calling [] on a nil object, but the spec says @location should default to nil, which is why I used Robert |
Fixes the following warning when run under -w:
aws-sdk-core-3.16.0/lib/seahorse/model/shapes.rb:39:
warning: instance variable @location not initialized
Fixes the following warning when run under -w:
aws-sdk-core-3.16.0/lib/aws-sdk-core/rest/request/endpoint.rb:52:
warning: shadowing outer local variable - parts
Fixes the following warning when run under -w:
aws-sigv4-1.0.2/lib/aws-sigv4/signer.rb:441:
warning: shadowing outer local variable - headers
Resolves GitHub issue aws#1696
* Doc updates [ci skip]
Contributor
Author
|
I reverted the commit that initialized the location field. I'll work on solving the warning in another way. |
awood45
approved these changes
Mar 12, 2018
Contributor
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warnings appear when running the sample code under QuickStart Guide to Using the AWS SDK for Ruby with warnings on:
The warnings are:
aws-sdk-core-3.16.0/lib/aws-sdk-core/rest/request/endpoint.rb:52: warning: shadowing outer local variable - partsaws-sigv4-1.0.2/lib/aws-sigv4/signer.rb:441: warning: shadowing outer local variable - headersaws-sdk-core-3.16.0/lib/seahorse/model/shapes.rb:39: warning: instance variable @location not initializedThese updates silence the warnings.