Skip to content

Commit 072d2ed

Browse files
authored
Merge pull request #1717 from rcrews/fix-qs-ex1-warnings
Fix QuickStart example #1 warnings
2 parents 0fbf24d + 49d6b01 commit 072d2ed

4 files changed

Lines changed: 13 additions & 6 deletions

File tree

gems/aws-sdk-core/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ Unreleased Changes
66

77
* Feature - Updated Aws::STS::Client with the latest API changes.
88

9+
* Issue - Fix Ruby warnings: Shadowed local variables "parts" and "headers"
10+
911
3.16.0 (2018-02-20)
1012
------------------
1113

gems/aws-sdk-core/lib/aws-sdk-core/rest/request/endpoint.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,11 @@ def param_name(placeholder)
4949

5050
def apply_querystring_params(uri, params)
5151
# collect params that are supposed to be part of the query string
52-
parts = @rules.shape.members.inject([]) do |parts, (member_name, member_ref)|
52+
parts = @rules.shape.members.inject([]) do |prts, (member_name, member_ref)|
5353
if member_ref.location == 'querystring' && !params[member_name].nil?
54-
parts << [member_ref, params[member_name]]
54+
prts << [member_ref, params[member_name]]
5555
end
56-
parts
56+
prts
5757
end
5858
querystring = QuerystringBuilder.new.build(parts)
5959
querystring = [@query_prefix, querystring == '' ? nil : querystring].compact.join('&')

gems/aws-sigv4/CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
Unreleased Changes
22
------------------
33

4+
1.0.2 (2018-02-21)
5+
------------------
6+
7+
* Issue - Fix Ruby warning: shadowed local variable "headers"
8+
49
1.0.2 (2017-08-31)
510
------------------
611

gems/aws-sigv4/lib/aws-sigv4/signer.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -438,11 +438,11 @@ def signed_headers(headers)
438438
end
439439

440440
def canonical_headers(headers)
441-
headers = headers.inject([]) do |headers, (k,v)|
441+
headers = headers.inject([]) do |hdrs, (k,v)|
442442
if @unsigned_headers.include?(k)
443-
headers
443+
hdrs
444444
else
445-
headers << [k,v]
445+
hdrs << [k,v]
446446
end
447447
end
448448
headers = headers.sort_by(&:first)

0 commit comments

Comments
 (0)