docs(ecs): document Podman as a Docker/Finch alternative#35933
docs(ecs): document Podman as a Docker/Finch alternative#35933mergify[bot] merged 3 commits intoaws:mainfrom
Conversation
|
Hi @pahud, @aws/aws-cdk-maintainers, and code owners When you have a moment, could you please review this PR? This update enhances the ECS documentation by adding Podman as a community-tested alternative to Docker/Finch, addressing configuration and setup gaps reported by users. It’s a documentation-only change aimed at improving developer experience when using CDK container builds without Docker licensing constraints. Your feedback and review would be greatly appreciated. |
07662b9 to
111249c
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
leonmk-aws
left a comment
There was a problem hiding this comment.
It looks like there a markdown linter has run on the docs, can you undo it to keep only the podman / finch etc.. changes ? Keeping the changes minimal allows for easier review. (And I suspect a whole section has been accidentally removed, see comments).
Pull request has been modified.
|
||||||||||||||
|
||||||||||||||
e2c229a to
81caa10
Compare
Pull request has been modified.
f165e82 to
fbb80e0
Compare
fbb80e0 to
aba1830
Compare
leonmk-aws
left a comment
There was a problem hiding this comment.
There are still finch machine commands, one section that is deleted. Please also remove all the changes that are not related to the explanation added in this PR (blank lines being removed, * being converted to _ etc).
Pull request has been modified.
856d27d to
c0d0c38
Compare
- Add Podman DOCKER_HOST configuration guidance to CONTRIBUTING.md - Document Finch and Podman as Docker alternatives in ECR assets README - Clarify Finch requires OS-specific DOCKER_HOST path (no machine inspect command) - Note Podman is community-tested while Finch has official AWS support Addresses reviewer feedback - removed finch machine inspect command and all unrelated formatting changes. Fixes aws#35833 Signed-off-by: SACHIN <[email protected]>
30be8c7 to
7842766
Compare
leonmk-aws
left a comment
There was a problem hiding this comment.
Thank you for updating the, LGTM
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Merge Queue Status✅ The pull request has been merged at 6b64a69 This pull request spent 20 hours 34 minutes 1 second in the queue, including 17 hours 51 minutes 54 seconds running CI. Required conditions to merge
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
docs(aws-ecs): Document Podman as a Docker/Finch alternative
Fixes #35833
Issue # (if applicable)
Closes #35833.
Reason for this change
Users are facing Docker licensing issues and seeking alternatives like Podman for CDK container builds. The current documentation only mentions Finch as a Docker alternative but lacks:
This creates a documentation gap that prevents users from successfully using Podman with CDK, even though it works with proper configuration.
Description of changes
1. Enhanced aws-ecr-assets README.md:
CDK_DOCKER=podmanandDOCKER_HOST=$(podman machine inspect...)2. Updated CONTRIBUTING.md:
3. Design decisions:
4. Alternatives considered:
Describe any new or updated permissions being added
No new or updated IAM permissions are being added. This is purely documentation enhancement.
Description of how you validated changes
Documentation validation:
Content validation:
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license