Skip to content

Commit f165e82

Browse files
SACHINSACHIN
authored andcommitted
fix(ecr-assets): address review feedback - remove finch machine inspect and restore formatting
- Remove DOCKER_HOST line from Finch example as 'finch machine inspect' command doesn't exist - Restore original compact formatting for cacheFrom/cacheTo example per reviewer feedback - No changes to CONTRIBUTING.md per reviewer request Addresses feedback from leonmk-aws
1 parent 58a0f08 commit f165e82

File tree

1 file changed

+2
-13
lines changed

1 file changed

+2
-13
lines changed

packages/aws-cdk-lib/aws-ecr-assets/README.md

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ variable in order to provide a custom Docker executable command or path. This ma
5858
be needed when building in environments where the standard docker cannot be executed
5959
(see https://github.com/aws/aws-cdk/issues/8460 for details).
6060

61-
6261
### Docker Alternatives
6362

6463
The CDK supports several Docker alternatives through the `CDK_DOCKER` environment variable:
@@ -67,7 +66,6 @@ The CDK supports several Docker alternatives through the `CDK_DOCKER` environmen
6766

6867
```bash
6968
export CDK_DOCKER=finch
70-
export DOCKER_HOST=$(finch machine inspect --format 'unix://{{.ConnectionInfo.PodmanSocket.Path}}')
7169
```
7270

7371
#### Podman (Community-tested)
@@ -152,17 +150,8 @@ import { DockerImageAsset, Platform } from 'aws-cdk-lib/aws-ecr-assets';
152150

153151
const asset = new DockerImageAsset(this, 'MyBuildImage', {
154152
directory: path.join(__dirname, 'my-image'),
155-
cacheFrom: [
156-
{ type: 'registry', params: { ref: 'ghcr.io/myorg/myimage:cache' } },
157-
],
158-
cacheTo: {
159-
type: 'registry',
160-
params: {
161-
ref: 'ghcr.io/myorg/myimage:cache',
162-
mode: 'max',
163-
compression: 'zstd',
164-
},
165-
},
153+
cacheFrom: [{ type: 'registry', params: { ref: 'ghcr.io/myorg/myimage:cache' }}],
154+
cacheTo: { type: 'registry', params: { ref: 'ghcr.io/myorg/myimage:cache', mode: 'max', compression: 'zstd' }}
166155
});
167156
```
168157

0 commit comments

Comments
 (0)