Skip to content
This repository was archived by the owner on Nov 25, 2025. It is now read-only.

ci: Missing test import lint #1394

Merged
maru-ava merged 1 commit into from
Nov 10, 2025
Merged

ci: Missing test import lint #1394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions plugin/evm/atomic/vm/tx_gossip_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ import (
"github.com/ava-labs/coreth/plugin/evm/atomic"
"github.com/ava-labs/coreth/plugin/evm/config"
"github.com/ava-labs/coreth/plugin/evm/vmtest"
"github.com/ava-labs/coreth/utils"
"github.com/ava-labs/coreth/utils/utilstest"

avalancheatomic "github.com/ava-labs/avalanchego/chains/atomic"
Expand All @@ -45,7 +44,7 @@ func TestAtomicTxGossip(t *testing.T) {

snowCtx := snowtest.Context(t, snowtest.CChainID)
snowCtx.AVAXAssetID = ids.GenerateTestID()
validatorState := utils.NewTestValidatorState()
validatorState := utilstest.NewTestValidatorState()
snowCtx.ValidatorState = validatorState
memory := avalancheatomic.NewMemory(memdb.New())
snowCtx.SharedMemory = memory.NewSharedMemory(snowCtx.ChainID)
Expand Down Expand Up @@ -195,7 +194,7 @@ func TestAtomicTxPushGossipOutbound(t *testing.T) {

snowCtx := snowtest.Context(t, snowtest.CChainID)
snowCtx.AVAXAssetID = ids.GenerateTestID()
validatorState := utils.NewTestValidatorState()
validatorState := utilstest.NewTestValidatorState()
snowCtx.ValidatorState = validatorState
memory := avalancheatomic.NewMemory(memdb.New())
snowCtx.SharedMemory = memory.NewSharedMemory(snowCtx.ChainID)
Expand Down Expand Up @@ -265,7 +264,7 @@ func TestAtomicTxPushGossipInboundValid(t *testing.T) {

snowCtx := snowtest.Context(t, snowtest.CChainID)
snowCtx.AVAXAssetID = ids.GenerateTestID()
validatorState := utils.NewTestValidatorState()
validatorState := utilstest.NewTestValidatorState()
snowCtx.ValidatorState = validatorState
memory := avalancheatomic.NewMemory(memdb.New())
snowCtx.SharedMemory = memory.NewSharedMemory(snowCtx.ChainID)
Expand Down
4 changes: 2 additions & 2 deletions plugin/evm/tx_gossip_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import (
"github.com/ava-labs/coreth/plugin/evm/config"
"github.com/ava-labs/coreth/plugin/evm/upgrade/ap0"
"github.com/ava-labs/coreth/plugin/evm/vmtest"
"github.com/ava-labs/coreth/utils"
"github.com/ava-labs/coreth/utils/utilstest"

agoUtils "github.com/ava-labs/avalanchego/utils"
)
Expand All @@ -40,7 +40,7 @@ func TestEthTxGossip(t *testing.T) {
require := require.New(t)
ctx := t.Context()
snowCtx := snowtest.Context(t, snowtest.CChainID)
validatorState := utils.NewTestValidatorState()
validatorState := utilstest.NewTestValidatorState()
snowCtx.ValidatorState = validatorState

pk, err := secp256k1.NewPrivateKey()
Expand Down
4 changes: 2 additions & 2 deletions scripts/lint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,8 @@ function test_import_testing_only_in_tests {

IMPORT_TESTING=$(echo "${NON_TEST_GO_FILES}" | xargs grep -lP '^\s*(import\s+)?"testing"')
IMPORT_TESTIFY=$(echo "${NON_TEST_GO_FILES}" | xargs grep -l '"github.com/stretchr/testify')
IMPORT_FROM_TESTS=$(echo "${NON_TEST_GO_FILES}" | xargs grep -l '"github.com/ava-labs/coreth/tests/')
IMPORT_TEST_PKG=$(echo "${NON_TEST_GO_FILES}" | xargs grep -lP '"github.com/ava-labs/coreth/.*?test"')
IMPORT_FROM_TESTS=$(echo "${NON_TEST_GO_FILES}" | xargs grep -lP '"github.com/ava-labs/(?:avalanchego|coreth)/tests/')
IMPORT_TEST_PKG=$(echo "${NON_TEST_GO_FILES}" | xargs grep -lP '"github.com/ava-labs/(?:avalanchego|coreth)/.*?test"')

# TODO(arr4n): send a PR to add support for build tags in `mockgen` and then enable this.
# IMPORT_GOMOCK=$( echo "${NON_TEST_GO_FILES}" | xargs grep -l '"go.uber.org/mock');
Expand Down
2 changes: 1 addition & 1 deletion utils/snow.go → utils/utilstest/snow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Copyright (C) 2019-2025, Ava Labs, Inc. All rights reserved.
// See the file LICENSE for licensing terms.

package utils
package utilstest

import (
"context"
Expand Down
Loading