Skip to content
This repository was archived by the owner on Nov 25, 2025. It is now read-only.

Conversation

@alarso16
Copy link
Contributor

@alarso16 alarso16 commented Nov 6, 2025

Why this should be merged

When I was migrating the linters for a monorepo, I noticed a small test import mistake.

How this works

Disallows avalanchego testing imports in non-test packages

How this was tested

CI

Need to be documented?

No

Need to update RELEASES.md?

No

@alarso16 alarso16 self-assigned this Nov 6, 2025
@alarso16 alarso16 added the ci label Nov 6, 2025
@alarso16 alarso16 marked this pull request as ready for review November 6, 2025 21:08
@alarso16 alarso16 requested a review from a team as a code owner November 6, 2025 21:08
@alarso16 alarso16 force-pushed the alarso16/ci-lint-fixes branch from 214141c to 43eca87 Compare November 6, 2025 21:34
@alarso16 alarso16 changed the title ci: Missing lint cases ci: Missing test import lint Nov 6, 2025
@alarso16 alarso16 force-pushed the alarso16/ci-lint-fixes branch from 43eca87 to 20b3620 Compare November 6, 2025 21:42
@alarso16 alarso16 force-pushed the alarso16/ci-lint-fixes branch from 20b3620 to 62e937d Compare November 6, 2025 22:02
@maru-ava maru-ava added this pull request to the merge queue Nov 10, 2025
Merged via the queue into master with commit 7e583fa Nov 10, 2025
9 checks passed
@maru-ava maru-ava deleted the alarso16/ci-lint-fixes branch November 10, 2025 16:32
maru-ava added a commit that referenced this pull request Nov 13, 2025
Squashed commit of the following:

commit 7c56b58
Author: Austin Larson <[email protected]>
Date:   Mon Nov 10 16:38:50 2025 -0500

    fix: dereference on error

commit 042e7af
Author: Austin Larson <[email protected]>
Date:   Mon Nov 10 16:35:30 2025 -0500

    fix: go mod tidy

commit cc96105
Author: Austin Larson <[email protected]>
Date:   Mon Nov 10 16:19:11 2025 -0500

    fix: small cleanups

commit be72d2a
Merge: 9e93322 6ef531e
Author: Austin Larson <[email protected]>
Date:   Mon Nov 10 15:35:45 2025 -0500

    Merge remote-tracking branch 'origin/master' into alarso16/firewood-v0.0.14

commit 9e93322
Author: Austin Larson <[email protected]>
Date:   Mon Nov 10 15:35:26 2025 -0500

    Import correct dep

commit 6ef531e
Author: Jonathan Oppenheimer <[email protected]>
Date:   Mon Nov 10 14:48:08 2025 -0500

    style: enable errcheck linter (#1203)

    Signed-off-by: Jonathan Oppenheimer <[email protected]>
    Signed-off-by: Jonathan Oppenheimer <[email protected]>
    Co-authored-by: Austin Larson <[email protected]>
    Co-authored-by: Stephen Buttolph <[email protected]>

commit c06f5df
Author: Jonathan Oppenheimer <[email protected]>
Date:   Mon Nov 10 14:03:37 2025 -0500

    chore: Add lint link check job (#1392)

    Signed-off-by: Jonathan Oppenheimer <[email protected]>
    Co-authored-by: Austin Larson <[email protected]>

commit 7e583fa
Author: Austin Larson <[email protected]>
Date:   Mon Nov 10 11:21:23 2025 -0500

    ci: Missing test import lint (#1394)

commit f5b6f85
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Nov 6 16:12:25 2025 -0500

    build(deps): bump github.com/consensys/gnark-crypto from 0.12.1 to 0.18.1 (#1385)

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Jonathan Oppenheimer <[email protected]>

commit cd55125
Author: Austin Larson <[email protected]>
Date:   Thu Nov 6 13:25:32 2025 -0500

    build: Firewood upgrade v0.0.14

commit f1525b7
Author: Austin Larson <[email protected]>
Date:   Wed Nov 5 16:37:18 2025 -0500

    ci: Add lint-fix to taskfile (#1391)

    Signed-off-by: Austin Larson <[email protected]>
    Co-authored-by: Jonathan Oppenheimer <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants