Name and configure the H upgrade: Helicon #4478
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanOppenheimer
changed the title
maru-ava
previously approved these changes
Nov 6, 2025
StephenButtolph
previously requested changes
Nov 6, 2025
Contributor
There was a problem hiding this comment.
Please model this PR after #3964
Bonus points for adding tests to automatically discover discrepancies between this PR and the above linked PR.
JonathanOppenheimer
force-pushed
the
JonathanOppenheimer/helicon-upgrade
branch
from
2829726 to
efe2db4
Compare
JonathanOppenheimer
requested review from
joshua-kim and
meaghanfitzgerald
as code owners
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]>
Member
Author
|
|
Signed-off-by: Stephen Buttolph <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]>
| // not passed through the RPC protocol, but we need to set it to match the | ||
| // expected value for comparison. | ||
| // TODO(JonathanOppenheimer): this should definitely be removed from the config | ||
| gotConfig.GraniteEpochDuration = wantConfig.GraniteEpochDuration |
Member
Author
There was a problem hiding this comment.
another reason this should be removed.
Comment on lines
+265
to
+284
| // convert to protobuf | ||
| pbUpgrades := &vmpb.NetworkUpgrades{ | ||
| ApricotPhase_1Time: grpcutils.TimestampFromTime(wantConfig.ApricotPhase1Time), | ||
| ApricotPhase_2Time: grpcutils.TimestampFromTime(wantConfig.ApricotPhase2Time), | ||
| ApricotPhase_3Time: grpcutils.TimestampFromTime(wantConfig.ApricotPhase3Time), | ||
| ApricotPhase_4Time: grpcutils.TimestampFromTime(wantConfig.ApricotPhase4Time), | ||
| ApricotPhase_4MinPChainHeight: wantConfig.ApricotPhase4MinPChainHeight, // not passed through the RPC protocol | ||
| ApricotPhase_5Time: grpcutils.TimestampFromTime(wantConfig.ApricotPhase5Time), | ||
| ApricotPhasePre_6Time: grpcutils.TimestampFromTime(wantConfig.ApricotPhasePre6Time), | ||
| ApricotPhase_6Time: grpcutils.TimestampFromTime(wantConfig.ApricotPhase6Time), | ||
| ApricotPhasePost_6Time: grpcutils.TimestampFromTime(wantConfig.ApricotPhasePost6Time), | ||
| BanffTime: grpcutils.TimestampFromTime(wantConfig.BanffTime), | ||
| CortinaTime: grpcutils.TimestampFromTime(wantConfig.CortinaTime), | ||
| CortinaXChainStopVertexId: wantConfig.CortinaXChainStopVertexID[:], // not passed through the RPC protocol | ||
| DurangoTime: grpcutils.TimestampFromTime(wantConfig.DurangoTime), | ||
| EtnaTime: grpcutils.TimestampFromTime(wantConfig.EtnaTime), | ||
| FortunaTime: grpcutils.TimestampFromTime(wantConfig.FortunaTime), | ||
| GraniteTime: grpcutils.TimestampFromTime(wantConfig.GraniteTime), | ||
| HeliconTime: grpcutils.TimestampFromTime(wantConfig.HeliconTime), | ||
| } |
Contributor
There was a problem hiding this comment.
This is copied from vm_client.go. This should be made into a helper (similarly to how convertNetworkUpgrades is a helper the other way).
Comment on lines
+289
to
+292
| // not passed through the RPC protocol, but we need to set it to match the | ||
| // expected value for comparison. | ||
| // TODO(JonathanOppenheimer): this should definitely be removed from the config | ||
| gotConfig.GraniteEpochDuration = wantConfig.GraniteEpochDuration |
Contributor
There was a problem hiding this comment.
Isn't this just a bug? If we are passing through things like ApricotPhase_4MinPChainHeight and CortinaXChainStopVertexId, I'd expect GraniteEpochDuration to be passed through.
| // TestConvertNetworkUpgrades_AllFieldsHandled ensures that all fields in | ||
| // upgrade.Config are properly handled when converting from the gRPC protobuf message. | ||
| func TestConvertNetworkUpgrades_AllFieldsHandled(t *testing.T) { | ||
| wantConfig := upgrade.Default |
Contributor
There was a problem hiding this comment.
Can we test this for all of:
constants.MainnetID
constants.FujiID
constants.LocalID
constants.UnitTestID
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This is perhaps the most important PR I have ever opened. We held an internal vote about what to name the next upgrade, and @bernard-avalabs's suggestion won!
How this works
This is just structural code for when logic for the next upgrade is added.
How this was tested
CI
Need to be documented in RELEASES.md?
No