Add Granite to the upgrade.Config
#3964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
requested review from
a team and
rrazvan1
and removed request for
a team
StephenButtolph
requested review from
maru-ava and
meaghanfitzgerald
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the Granite network upgrade, enabling the system to target and trigger Granite-specific logic during upgrades and testing.
- Adds GraniteTime field conversion in the RPC server and client
- Updates configuration, test fixtures, and workflows to replace "Fortuna" with "Granite" where applicable
- Updates proto and API documentation to include GraniteTime
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| vms/rpcchainvm/vm_server.go | Converts and assigns GraniteTime from the protobuf upgrades |
| vms/rpcchainvm/vm_client.go | Includes GraniteTime in the initialization request |
| upgrade/upgradetest/fork.go | Adds Granite to the network upgrade enum and updates Latest accordingly |
| upgrade/upgradetest/config.go | Sets GraniteTime in configuration with fallthrough to Fortuna case |
| upgrade/upgrade.go | Adds GraniteTime defaults in various upgrade configurations |
| tests/fixture/e2e/flags.go | Replaces activateFortuna flag with activateGranite flag |
| tests/e2e/e2e_test.go | Updates logic to activate Granite upgrade timing in e2e tests |
| proto/vm/vm.proto | Adds granite_time field to the NetworkUpgrades message |
| api/info/service.md | Updates API response examples to include graniteTime |
| .github/workflows/ci.yml | Updates workflow and artifacts for Granite e2e tests |
yacovm
approved these changes
May 15, 2025
maru-ava
approved these changes
May 15, 2025
Contributor
maru-ava
left a comment
maru-ava
left a comment
There was a problem hiding this comment.
Testing/CI changes LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Allows us to start developing code targeting the G-upgrade.
How this works
Graniteto theupgrade.ConfigHow this was tested
CI
Need to be documented in RELEASES.md?