Conversation
nazar-pc
requested review from
NingLin-P,
rg3l3dr and
shamil-gadelshin
as code owners
nazar-pc
force-pushed
the
upgrade-substrate
branch
from
7c229ad to
2f9bad9
Compare
|
Removed custom |
nazar-pc
force-pushed
the
upgrade-substrate
branch
from
2f9bad9 to
f5e261a
Compare
|
This seems odd and likely not related to this PR?
Both macOS jobs are impacted: |
|
@DaMandal0rian I think this is something for you to fix |
teor2345
left a comment
teor2345
left a comment
There was a problem hiding this comment.
Looks good to me, but I don’t have the background to review some of it in detail.
I had one question about task handling, but it’s not a blocker.
Interesting, other PRs passed when I re-ran the tests, maybe it was a temporary issue, or fixed by #3079: |
# Conflicts: # crates/pallet-offences-subspace/Cargo.toml # crates/pallet-subspace/Cargo.toml # crates/sc-consensus-subspace/src/verifier.rs # crates/subspace-runtime/Cargo.toml # test/subspace-test-runtime/Cargo.toml
|
Merge only had minor |
| tx_handler_controller, | ||
| network_starter, | ||
| sync_service, | ||
| _block_downloader, |
There was a problem hiding this comment.
Block downloader will be required in the domain snap-sync.
There was a problem hiding this comment.
It is still there, just inside build_network. I have no idea why it was surfaced here, it is actually build_network's argument 😕
There was a problem hiding this comment.
I meant - domain snap sync requires that variable.
There was a problem hiding this comment.
This is how we request last confirmed domain block.
There was a problem hiding this comment.
Then you'll simply have to construct default block downloader explicitly hand it over as an argument here. There is a public function in sc-service now that makes it more convenient to do.
There was a problem hiding this comment.
Can you give me more hints or show me the correct function?
There was a problem hiding this comment.
build_default_block_downloader
teor2345
left a comment
teor2345
left a comment
There was a problem hiding this comment.
Merge looks good, even if large
4 participants
This upgrades Substrate to
stable2409upstream release.A lot of changes are caused by my refactoring of syncing implementation. I didn't take advantage of it yet to reduce the diff.
I have rebased most of the patches we had that are not yet upstreamed, notable exception is Ved's early runtime patch for state version and some of Shamil's patches for Snap sync that are no longer needed (and I have simplified the remaining since they re-exported more than needed with latest upstream refactoring).
On top of stable release I have also backported following PRs that were already merged into
masteror remain open, but have a good chance of getting in soon-ish:RuntimeVerisontype and usesystem_versionto derive extrinsics rootStateVersioninstead ofV0paritytech/polkadot-sdk#4257sp_runtime::RuntimeStringand replace withCow<'static, str>orStringdepending on use case paritytech/polkadot-sdk#5693 allowed to get rid ofpatch_domain_runtime_versionAll of this is in https://github.com/autonomys/polkadot-sdk/tree/subspace-v8, top commit of which is used in this PR.
Frontier has unmerged polkadot-evm/frontier#1504, which I cloned into https://github.com/autonomys/frontier/tree/subspace-v9 and used here.
I recommend ignoring
.tomlfiles during review due to trivial changes (mostly just hash updates and minor dependency changes where necessary).Code contributor checklist: