Conversation
shamil-gadelshin
approved these changes
Aug 14, 2024
Contributor
shamil-gadelshin
left a comment
There was a problem hiding this comment.
Tested in #2972
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surprisingly easy upgrade this time.
Thanks to upstreaming of patches we no longer need to update frontier fork, we can just use upstream instead.
There were also less changes than usual, here are those that I found interesting:
health/readiness endpointparitytech/polkadot-sdk#4802 (@DaMandal0rian you may find this useful, also we should probably update Dockerfile to use it and maybe remove it from docker-compose examples since I think it'll inherit from Dockerfile in that case)tracing::logwork in the runtime paritytech/polkadot-sdk#4863 will finally allow us to removelogfrom runtime and usetracingeverywhereNot much happened on frontier side since last update.
I even updated
libp2pthat while had a few breaking changes, those were minor and mostly mechanical for us. I still had to updatelitep2pfork to not bring OpenSSL in, but that will hopefully become unnecessary soon with paritytech/litep2p#161 finally resolved.Our fork is much lighter on patches this time around as well thanks to upstreaming and one more patch will go away soon with upstreaming of paritytech/polkadot-sdk#4257. Very nice trajectory even though we'll not be able to use unmodified upstream in short- to mid-term future.
Code contributor checklist: