Conversation
teor2345
left a comment
There was a problem hiding this comment.
Looks good, just some optional suggestions for making the docs clearer.
nazar-pc
left a comment
There was a problem hiding this comment.
Looks like a basic setup, I don't have any opinion on the actual parameters though, would be nice if Dariia could take a look
|
@vedhavyas can you clarify this?
Does this refer to this election? If so, you're right, we don't want that yet. |
|
@vedhavyas to be able to test this on devnet, can we have voting/enactment period equal to something like 5 min in devnet spec? |
Yes
This should be possible through |
|
I think genesis config option would be preferred, feature seems fragile, but if we need it as one-off test and remove shortly after than that'll work too. |
dariolina
left a comment
There was a problem hiding this comment.
Looks good to me, dk if anyone has comments on the last commit
teor2345
left a comment
There was a problem hiding this comment.
Re-approving after chain spec update
|
@vedhavyas can we get conflicts resolved and merge this? |
|
This will likely conflict with #2969 that is about to be merged |
|
Would be great to get this in today. |
This PR adds Council and Democracy(scope limited, read notes) to consensus runtime.
Council:
Democracy:
For the democracy, at the moment instead of anyone submitting the proposal, the origin is set to any council member. So only a council member can open proposal through democracy directly. This should be changed when we want anyone to submit proposals to democracy.
I have also left TODO for parameters where necessary and also enabled instant execution for democracy. Ideally, in mainnet this Instant execution may not be required.
cc: @dariolina @jfrank-summit @nazar-pc
Please take a look and let me know if you have any questions/concerns
Code contributor checklist: