Conversation
83f5f7b to
6b13935
Compare
NingLin-P
approved these changes
Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Substrate to polkadot-sdk version 1.10.1, which is latest as of right now.
Interestingly, the way Parity maintainers do releases, there were annoying (trivial) merge conflicts between their release branches, but I decided to merge changes into
subpace-v4rather than creatingsubspace-v5due to our changes not conflicting with upstream.There are a few minor breaking changes to the APIs we are using, but nothing special this time. Frontier's
masteralso applied cleanly.Construct Runtime v2 below seems experimental for now, but looks better from IDE support perspective even though it'll be more verbose.
Interesting PRs on Substrate side:
keyringin runtimes paritytech/polkadot-sdk#2044TransactionExtensionas a replacement forSignedExtension(#2280)" paritytech/polkadot-sdk#3665pollhook and new System callbacks paritytech/polkadot-sdk#1781The only potentially interesting PRs on frontier side are these:
P.S. Running this version locally already, seems to work so far.
Code contributor checklist: