Add Kademlia stats logging for subspace-networking crates.#2280
Add Kademlia stats logging for subspace-networking crates.#2280
Conversation
nazar-pc
left a comment
There was a problem hiding this comment.
Do you really need to print it though? I think this should be a metric instead. I hope we can remove handle_periodic_tasks completely at some point and make it reactive instead as it should be.
It's helpful to have this in the log to understand how the process goes. As to metrics, they are also helpful. Let me know what metrics do you lack and we will start accumulating those (with |
|
I mean these parameters should probably be metrics in the first place, same for "Current connections and limits" and they should be updated as changes happen, not once every few seconds. |
nazar-pc
left a comment
There was a problem hiding this comment.
Okay, I don't this is blocking, let's consider metrics as a future upgrade
This PR periodical adds logging of the Kademlia buckets (total known peer number and number of peers without addresses).
Code contributor checklist: