Merged
Conversation
nazar-pc
requested review from
0xjeremyfrank,
NingLin-P,
ParthDesai,
rahulksnv and
vedhavyas
1 task
vedhavyas
reviewed
Sep 23, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for regression introduced in #1980
Basically during archiver restart it was ignoring that blocks need to be at a certain depth before they can be archivd. One user ended up in a situation where their block was exactly the block in one of the segment headers: https://forum.subspace.network/t/thread-main-panicked-at-must-always-set-if-there-is-no-logical-error/1901
The fix here is to restrict what blocks are supposed to be archived at this point and which are not yet.
This can also potentially cause nodes to archive incorrect history if before restart they wereon a short fork and in similarly unlucky conditions as the post on the forum above.
Code contributor checklist: