Conversation
1 task
…node restart, improve error handling by removing incorrect `.expect()` calls
25a4f3e to
9fd90d4
Compare
Member
Author
|
Rebased on |
vedhavyas
approved these changes
Sep 20, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you ever restarted your node and though that archiver takes a really long time to start you were absolutely right!
This set of changes turns this (note timestamps):
Into this:
That is 3m41s vs 16s initialization time!
I expect similarly massive changes in block import performance (for essentialy empty blocks) once paritytech/polkadot-sdk#1598 or similar is incorporated.
Resolves #1852
Code contributor checklist: