Skip to content

Avoid using path URL for workspace Git dependencies in requirements.txt #14288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
charliermarsh merged 1 commit into from
Jun 26, 2025
Merged

Avoid using path URL for workspace Git dependencies in requirements.txt #14288

charliermarsh merged 1 commit into from
Jun 26, 2025

Conversation

@charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Jun 26, 2025

Summary

Closes #13020.

@charliermarsh charliermarsh changed the title Avoid using path URL for workspace Git dependencies in requirements.txt Avoid using path URL for workspace Git dependencies in requirements.txt Jun 26, 2025
@charliermarsh charliermarsh requested a review from konstin June 26, 2025 17:54
@charliermarsh charliermarsh added the bug Something isn't working label Jun 26, 2025
@charliermarsh
Copy link
Member Author

charliermarsh commented Jun 26, 2025

Need to figure out a test, but it does resolve the linked issue.

@charliermarsh charliermarsh temporarily deployed to uv-test-registries June 26, 2025 17:57 — with GitHub Actions Inactive
konstin
konstin reviewed Jun 26, 2025
View reviewed changes
Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good, but we need the test

@charliermarsh charliermarsh force-pushed the charlie/ver branch 2 times, most recently from 5ab05f0 to 0d43344 Compare June 26, 2025 19:08
@charliermarsh
Copy link
Member Author

charliermarsh commented Jun 26, 2025

@konstin -- Added.

@charliermarsh charliermarsh temporarily deployed to uv-test-registries June 26, 2025 19:10 — with GitHub Actions Inactive
konstin
konstin reviewed Jun 26, 2025
View reviewed changes
crates/uv-redacted/src/lib.rs

fn is_ssh_git_username(url: &Url) -> bool {
matches!(url.scheme(), "ssh" | "git+ssh") && url.username() == "git" && url.password().is_none()
matches!(url.scheme(), "ssh" | "git+ssh" | "git+https")
Copy link
Member

@konstin konstin Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc this was cause ssh needs a username while https doesn't, but it doesn't hurt either.

@charliermarsh charliermarsh enabled auto-merge (squash) June 26, 2025 19:27
@charliermarsh charliermarsh temporarily deployed to uv-test-registries June 26, 2025 19:29 — with GitHub Actions Inactive
@charliermarsh charliermarsh temporarily deployed to uv-test-registries June 26, 2025 19:41 — with GitHub Actions Inactive
@charliermarsh charliermarsh merged commit 05ab266 into main Jun 26, 2025
87 checks passed
@charliermarsh charliermarsh deleted the charlie/ver branch June 26, 2025 19:48
@BrewTestBot BrewTestBot mentioned this pull request Jun 27, 2025
Merged
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jun 29, 2025
@tmeijn
build(deps): update astral-sh/uv to v0.7.16
7aeb568 
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.7.14` -> `0.7.16` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>astral-sh/uv (astral-sh/uv)</summary>

### [`v0.7.16`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0716)

[Compare Source](astral-sh/uv@0.7.15...0.7.16)

##### Python

- Add Python 3.14.0b3

See the
[`python-build-standalone` release notes](https://github.com/astral-sh/python-build-standalone/releases/tag/20250626)
for more details.

##### Enhancements

- Include path or URL when failing to convert in lockfile ([#&#8203;14292](astral-sh/uv#14292))
- Warn when `~=` is used as a Python version specifier without a patch version ([#&#8203;14008](astral-sh/uv#14008))

##### Preview features

- Ensure preview default Python installs are upgradeable ([#&#8203;14261](astral-sh/uv#14261))

##### Performance

- Share workspace cache between lock and sync operations ([#&#8203;14321](astral-sh/uv#14321))

##### Bug fixes

- Allow local indexes to reference remote files ([#&#8203;14294](astral-sh/uv#14294))
- Avoid rendering desugared prefix matches in error messages ([#&#8203;14195](astral-sh/uv#14195))
- Avoid using path URL for workspace Git dependencies in `requirements.txt` ([#&#8203;14288](astral-sh/uv#14288))
- Normalize index URLs to remove trailing slash ([#&#8203;14245](astral-sh/uv#14245))
- Respect URL-encoded credentials in redirect location ([#&#8203;14315](astral-sh/uv#14315))
- Lock the source tree when running setuptools, to protect concurrent builds ([#&#8203;14174](astral-sh/uv#14174))

##### Documentation

- Note that GCP Artifact Registry download URLs must have `/simple` component ([#&#8203;14251](astral-sh/uv#14251))

### [`v0.7.15`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0715)

[Compare Source](astral-sh/uv@0.7.14...0.7.15)

##### Enhancements

- Consistently use `Ordering::Relaxed` for standalone atomic use cases ([#&#8203;14190](astral-sh/uv#14190))
- Warn on ambiguous relative paths for `--index` ([#&#8203;14152](astral-sh/uv#14152))
- Skip GitHub fast path when rate-limited ([#&#8203;13033](astral-sh/uv#13033))
- Preserve newlines in `schema.json` descriptions ([#&#8203;13693](astral-sh/uv#13693))

##### Bug fixes

- Add check for using minor version link when creating a venv on Windows ([#&#8203;14252](astral-sh/uv#14252))
- Strip query parameters when parsing source URL ([#&#8203;14224](astral-sh/uv#14224))

##### Documentation

- Add a link to PyPI FAQ to clarify what per-project token is ([#&#8203;14242](astral-sh/uv#14242))

##### Preview features

- Allow symlinks in the build backend ([#&#8203;14212](astral-sh/uv#14212))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC42Mi4xIiwidXBkYXRlZEluVmVyIjoiNDAuNjIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@konstin konstin konstin approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect pip compile for git subdirectory dependency

3 participants

@charliermarsh @konstin