Incorrect pip compile for git subdirectory dependency

[bnaul]

Summary

Example requirements.in:

git+https://github.com/PrefectHQ/prefect.git#subdirectory=src/integrations/prefect-dask

Compiling gives a weird-looking relative reference for prefect that does not install correctly

➜ uv pip compile requirements.in | grep '^prefect'
Resolved 105 packages in 193ms
prefect @ ../../../@562b964535b46f586b9b12808462956ed2f90c5a
prefect-dask @ git+https://github.com/PrefectHQ/prefect.git@562b964535b46f586b9b12808462956ed2f90c5a#subdirectory=src/integrations/prefect-dask

The same thing happens if you declare prefect in requirements.in, but adding prefect as a git+ dependency does work.

Platform

MacOS 15 ARM64

Version

uv 0.6.14 (Homebrew 2025-04-09)

Python version

3.13.2, 3.10.16

[charliermarsh]

Thanks, this is definitely a bug. I believe that's the path to the prefect root within our cache. We fix these up in a variety of places, but we might be missing one? Or there's something else going on. @konstin has some context here too, I think.

[konstin]

The problem is that we use the incorrect given value for the path-in-git case, and the given value is what's displayed:

uv/crates/uv-distribution/src/metadata/lowering.rs

Lines 691 to 713 in 4b34851

	let url = VerbatimUrl::from_path(path, base)?.with_given(path.to_string_lossy());
	let install_path = url
	.to_file_path()
	.map_err(|()| LoweringError::RelativeTo(io::Error::other("Invalid path in file URL")))?;
	let is_dir = if let Ok(metadata) = install_path.metadata() {
	metadata.is_dir()
	} else {
	install_path.extension().is_none()
	};
	if is_dir {
	if let Some(git_member) = git_member {
	let subdirectory = uv_fs::relative_to(install_path, git_member.fetch_root)
	.expect("Workspace member must be relative");
	let subdirectory = uv_fs::normalize_path_buf(subdirectory);
	return Ok(RequirementSource::Git {
	git: git_member.git_source.git.clone(),
	subdirectory: if subdirectory == PathBuf::new() {
	None
	} else {
	Some(subdirectory.into_boxed_path())
	},
	url,

[charliermarsh]

Oh interesting. I wonder why that hasn't affected use elsewhere. Honestly, we might want to drop given entirely for sources? given mostly existed to help with preserving environment variables in requirements.txt files.

[charliermarsh]

I can take a look from here @konstin.