This repository was archived by the owner on Oct 6, 2025. It is now read-only.
fix(sync): create namespace before dry-run #731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #731 +/- ##
==========================================
- Coverage 54.26% 53.75% -0.51%
==========================================
Files 64 64
Lines 6164 6531 +367
==========================================
+ Hits 3345 3511 +166
- Misses 2549 2743 +194
- Partials 270 277 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
|
Member
Author
|
@crenshaw-dev tested in argoproj/argo-cd#23304 and user confirmed the fix is good argoproj/argo-cd#21788 (comment) |
pjiang-dev
reviewed
Jun 11, 2025
pjiang-dev
approved these changes
Jun 13, 2025
crenshaw-dev
approved these changes
Jun 16, 2025
RoelofKuijpers
pushed a commit
to RoelofKuijpers/gitops-engine
that referenced
this pull request
Jul 29, 2025
Signed-off-by: Roelof Kuijpers <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #708 reverted by #730
Fixes argoproj/argo-cd#21788
Tested in Argo CD by argoproj/argo-cd#23304